Skip to content

Fix/underscore account hostname#2898

Open
Pazuzzu wants to merge 2 commits into
snowflakedb:mainfrom
Pazuzzu:fix/underscore-account-hostname
Open

Fix/underscore account hostname#2898
Pazuzzu wants to merge 2 commits into
snowflakedb:mainfrom
Pazuzzu:fix/underscore-account-hostname

Conversation

@Pazuzzu

@Pazuzzu Pazuzzu commented Jun 4, 2026

Copy link
Copy Markdown
  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue
    to your PR.

Fixes #1839
The async connector fails with SSL hostname mismatch on Python 3.11+ when the account name contains underscores (e.g. my_org_account), because the resulting hostname is rejected during TLS verification.

I saw that it's already being discussed in #1839. @sfc-gh-dszmolka's test confirmed that both _ and - resolve to the same account.
(I've seen that the official Snowflake docs also document this now in: https://docs.snowflake.com/en/user-guide/admin-account-identifier)

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  2. Please describe how your code solves the related issue.

This one-liner in construct_hostname() normalizes underscores to hyphens before building the FQDN, same approach dbt-snowflake shipped in dbt-labs/dbt-snowflake#1068.

Note: this reopens #2897, which was closed for administrative reasons unrelated to the code.

@Pazuzzu Pazuzzu requested a review from a team as a code owner June 4, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNOW-996175: Support for RFC1123 compliant Snowflake tenancy FQDN

1 participant